Merged
Conversation
pablobm
reviewed
Jan 20, 2022
Collaborator
pablobm
left a comment
pablobm
left a comment
There was a problem hiding this comment.
Thank you for this :-) Just one thing that I think can be improved.
Collaborator
|
@jhang-jhe-wei - Could you please rebase? The specs (I don't know why) are failing and I can't merge, but it looks like a rebase should fix it. |
nickcharlton
force-pushed
the
main
branch
2 times, most recently
from
90815b2 to
2a1a6cf
Compare
If you have ActiveRecord i18n translation of the model you don't need to do
anything extra, if not, make an ActiveRecord i18n translation of the model.
e.g.:
The recipe has many recipe items.
```ruby
ATTRIBUTE_TYPES = {
recipe_items: Field::HasMany,
id: Field::Number,
name: Field::String,
package_spec: Field::String,
remark: Field::String,
created_at: Field::DateTime,
updated_at: Field::DateTime,
}.freeze
```
```yaml
zh-TW:
activerecord:
models:
recipe: 配方表
recipe_item: 材料
```
Member
|
Thanks for opening this PR! I rebased and tidied up the commit so we could get it merged. |
shadoath
pushed a commit
to rinsed-org/administrate
that referenced
this pull request
Mar 12, 2025
If you have ActiveRecord i18n translation of the model you don't need to do
anything extra, if not, make an ActiveRecord i18n translation of the model.
e.g.:
The recipe has many recipe items.
```ruby
ATTRIBUTE_TYPES = {
recipe_items: Field::HasMany,
id: Field::Number,
name: Field::String,
package_spec: Field::String,
remark: Field::String,
created_at: Field::DateTime,
updated_at: Field::DateTime,
}.freeze
```
```yaml
zh-TW:
activerecord:
models:
recipe: 配方表
recipe_item: 材料
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field::HasMany i18n
How to Use?
If you have ActiveRecord i18n translation of the model you don't need to do anything extra, if not, make an ActiveRecord i18n translation of the model.
Example
The recipe has many recipe items.